Added some more comments

aphiria · Jun 23, 2023 · ad701f8 · ad701f8
1 parent 6932e96
commit ad701f8
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 6 deletions.
diff --git a/tests/Integration/Demo/Auth/IMockedAuthenticator.php b/tests/Integration/Demo/Auth/IMockedAuthenticator.php
@@ -10,6 +10,8 @@
 
 /**
  * Defines the interface for mocked authenticators to implement
+ *
+ * TODO: This should likely be refactored into Aphiria
  */
 interface IMockedAuthenticator extends IAuthenticator
 {

diff --git a/tests/Integration/Demo/Users/UserTest.php b/tests/Integration/Demo/Users/UserTest.php
@@ -36,12 +36,8 @@ protected function setUp(): void
         Container::$globalInstance?->resolve(GlobalDatabaseSeeder::class)->seed();
         $this->createTestingAuthenticator();
 
-        /**
-         * TODO
-         *
-         * Should also create mockable IAuthority
-         *      This should probably do some real work, eg looking up policy by name like the real one so that integration tests are slightly more realistic.  This would require some refactoring to either an abstract class or an overridable Authority class.
-         */
+        // TODO: Do I need a mockable authority?  It would prevent us from having to set up roles and all, but I wonder if that's actually desirable.
+        // TODO: The reason we mocked authentication is because it's a pain to set up the request, whereas setting up a principal to have the proper roles feels like something we should really be testing here.
     }
 
     protected function tearDown(): void