Fix placeholder on exact and partial filters #7547
Conversation
| use PHPUnit\Framework\Attributes\DataProvider; | ||
|
|
||
| /** | ||
| * @author Votre Nom <votre@email.com> |
There was a problem hiding this comment.
You need to replace it with your name and email
| } | ||
|
|
||
| if (':property' === $key) { | ||
| if (str_contains($key, ':property')) { |
There was a problem hiding this comment.
But then the handling of properties aware filters is skipped (see at line 150), by the continue (line 145).
There was a problem hiding this comment.
indeed we should just merge the below branch in this code
if (str_contains($key, ':property') || ((($f = $parameter->getFilter()) && is_a($f, PropertiesAwareInterface::class, true)) || $parameter instanceof PropertiesAwareInterface)) {
$p = [];
foreach ($propertyNames as $prop) {
$p[$this->nameConverter?->denormalize($prop) ?? $prop] = $prop;
}
$parameter = $parameter->withExtraProperties($parameter->getExtraProperties() + ['_properties' => $p]);
}
| properties: ['description', 'name'] | ||
| ), | ||
| ] | ||
| )] |
There was a problem hiding this comment.
can you add one to the https://github.com/api-platform/core/blob/main/tests/Fixtures/TestBundle/Entity/SearchFilterParameter.php class?
| $this->loadFixtures(); | ||
| } | ||
|
|
||
| #[DataProvider('partialFilterParameterProvider')] |
There was a problem hiding this comment.
please add these tests to the DoctrineTest file
| } | ||
|
|
||
| if (':property' === $key) { | ||
| if (str_contains($key, ':property')) { |
There was a problem hiding this comment.
indeed we should just merge the below branch in this code
if (str_contains($key, ':property') || ((($f = $parameter->getFilter()) && is_a($f, PropertiesAwareInterface::class, true)) || $parameter instanceof PropertiesAwareInterface)) {
$p = [];
foreach ($propertyNames as $prop) {
$p[$this->nameConverter?->denormalize($prop) ?? $prop] = $prop;
}
$parameter = $parameter->withExtraProperties($parameter->getExtraProperties() + ['_properties' => $p]);
}
|
@soyuka if @NathanPesneau isn't moving this along, could you do that instead? |
|
I'm indeed already working on this (haven't published anything yet). This week I'll have to be afk for a few days as I need to help dismantling a yurt where I live and it's a high priority. Anyways this is my top priority (had to push symfony 8 first). |
4 participants
Completes #7478