Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

15 export a list of supported chains #21

Merged
merged 14 commits into from
Dec 26, 2023
Merged

15 export a list of supported chains #21

merged 14 commits into from
Dec 26, 2023

Conversation

hiletmis
Copy link
Contributor

Closes #15

@hiletmis hiletmis linked an issue Dec 13, 2023 that may be closed by this pull request
Export a list of supported chains #15
Closed
@bbenligiray
Copy link
Member

This is painful to review. What if you had the chain aliases in chains.json, but converted them into chain IDs using @api3/chains before exporting?

@hiletmis
Copy link
Contributor Author

@bbenligiray chain ids replaced with chain aliases

bbenligiray
bbenligiray reviewed Dec 18, 2023
View reviewed changes
src/index.js Outdated Show resolved Hide resolved
@bbenligiray bbenligiray self-requested a review December 26, 2023 15:34
bbenligiray
bbenligiray approved these changes Dec 26, 2023
View reviewed changes
Copy link
Member

@bbenligiray bbenligiray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my commits

@bbenligiray bbenligiray merged commit 7abe2b1 into main Dec 26, 2023
1 check passed
@bbenligiray bbenligiray deleted the 15-export-a-list-of-supported-chains branch December 26, 2023 15:35
@hiletmis
Copy link
Contributor Author

Thanks for the improvements

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bbenligiray bbenligiray bbenligiray approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Export a list of supported chains
2 participants
@hiletmis @bbenligiray