This repository was archived by the owner on Nov 8, 2024. It is now read-only.
Remove sinatra #26
Merged
Remove sinatra #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
honzajavorek
force-pushed
the
honzajavorek/remove-sinatra
branch
5 times, most recently
from
52e0b7a to
8cccfdf
Compare
honzajavorek
force-pushed
the
honzajavorek/remove-sinatra
branch
from
8cccfdf to
66f7356
Compare
|
Please feel free to merge this right away if it's good to go, don't wait for me to get back to it 🙂 |
kylef
approved these changes
Apr 23, 2019
|
|
||
| Before do | ||
| puts "Killing server..." | ||
| system "for i in `ps axu | grep 'server.rb' | awk '{print $2}'`; do kill -9 $i; done > /dev/null 2>&1" | ||
| system "for i in `ps axu | grep 'server.js' | awk '{print $2}'`; do kill -9 $i; done > /dev/null 2>&1" |
There was a problem hiding this comment.
Would pkill -9 node server.js suffice?
There was a problem hiding this comment.
Perhaps, I'll be rewriting it in upcoming changes to address #6 as well.
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing sinatra, the Ruby web framework. Replacing it with a primitive, native Node.js implementation. I considered using
express.js, but it didn't seem to be worth all of its dependencies.Part of: apiaryio/dredd#917 (comment)