Rewrite from Ruby to Node.js #29
Conversation
honzajavorek
force-pushed
the
honzajavorek/remove-ruby
branch
from
4a27f13 to
847944a
Compare
package.json
Outdated
| @@ -2,14 +2,22 @@ | |||
| "name": "dredd-hooks-template", | |||
| "version": "1.0.0", | |||
| "description": "A meta-package to install the testing dependencies of the Dredd Hooks template test suite", | |||
| "engines": { | |||
| "node": ">=10" | |||
There was a problem hiding this comment.
Since this is the template for hooks, I would guess that hooks should work on the minimum version of Node that Dredd supports. Is there any reason for limiting to Node >= 10?
There was a problem hiding this comment.
Good point, addressed.
|
|
||
|
|
||
| const PROJECT_DIR = path.join(__dirname, '..') | ||
| const PROJECT_DIR = path.join(__dirname, '..'); |
There was a problem hiding this comment.
Do you think it's worth adding eslint? (not for this PR though)
| const { Given, When, Then, Before, After } = require('cucumber'); | ||
|
|
||
|
|
||
| Before(function () { |
There was a problem hiding this comment.
In our ES6 style guide, this and all the closures below are not permitted as they miss function names.
| curl https://bootstrap.pypa.io/get-pip.py -o get-pip.py | ||
| sudo python get-pip.py | ||
| sudo pip install dredd_hooks | ||
| command: sudo pip install dredd_hooks |
There was a problem hiding this comment.
Not saying you have to change this, but you can avoid using sudo with:
$ pip install dredd_hooks --userThen to use any binary it provides:
$ export PATH="$HOME/.local/bin:$PATH"I believe Python would automatically pick up the library from ~/.local
There was a problem hiding this comment.
That's neat. I think it doesn't matter in CI, but it's good to know this is so easy now. (Or was it the same in the past as well? 🤔 )
|
@kylef I plan to add ESlint, but it's one of the last points in apiaryio/dredd#917 (comment). I didn't want to get hold back by that now. Thanks for the review! |
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Replacing all Ruby dependencies, Aruba, and 50 lines of Ruby code by 100 lines of Node.js code and a few npm dependencies, which won't collide with any other hooks handler language.
Closes #23, closes #6
I plan to provide Travis CI example and to update the README as a next step - noted in apiaryio/dredd#917 (comment)