This repository has been archived by the owner on Nov 8, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add CLI #42
Add CLI #42
Changes from all commits
6630678
5c9edd1
27cc517
448acb3
fa1e3da
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can also use
postinstall
npm hook for copying the files, so users could upgrade the package version using a default flow (npm outdated
/npm install ...
), and the hook would handle additional logic.Also account on the scenario that a user will upgrade the package as usual. I think we should ensure the package would contain expected files in any way.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's an interesting idea which didn't occur to me. One concern I'd have is that it would implicitly, without asking the user, copy some files over from the package to their code. I'm not sure whether it's not too invasive. I kind of like the explicit step user takes - they know what they're doing, they're doing it willingly, they can easily retry, etc.