Skip to content

Commit

Permalink
fix: Specify the same Chrome and Chromedriver version in tests (#173)
Browse files Browse the repository at this point in the history
Apparently, if you pass `chromedriver-version` to `setup-chromedriver`,
it will install the given Chromedriver version, but it will also install
latest Chrome which might not be compatible to the given Chromedriver
version.

There is now a better way to install the same Chrome and Chromedriver,
using [Chrome for
Testing](https://developer.chrome.com/blog/chrome-for-testing/) and `npx
@puppeteer/browsers install ...`.
  • Loading branch information
fnesveda authored Jul 27, 2023
1 parent 894a8c0 commit 475b230
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions .github/workflows/lint_and_test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -122,10 +122,10 @@ jobs:
with:
python-version: ${{ matrix.python-version }}

- name: Setup Chromedriver
uses: nanasess/setup-chromedriver@v2
with:
chromedriver-version: '113.0.5672.63'
- name: Install Chrome and Chromedriver
run: |
npx @puppeteer/browsers install chrome@113.0.5672.63
npx @puppeteer/browsers install chromedriver@113.0.5672.63
- name: Test Python templates
run: npm run test-python-templates
Expand Down

0 comments on commit 475b230

Please sign in to comment.