-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix tests #151
Fix tests #151
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I trust that it works now 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, good job
I originally wanted to do a simple change to migrate the secrets used in the tests in CI to use organization-level secrets instead of repo-level ones. But when I was doing that change, I found out the template tests don't work at all, so I got into a very deep rabbit hole and I had to rewrite them basically from scratch.
This:
There are still some issues:
0
even if the command fails, so it can't be relied on yet, I will fix it there and then update the tests here