Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Add configs to ts templates #295

Merged
merged 7 commits into from
Sep 24, 2024
Merged

fix: Add configs to ts templates #295

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
41adeb7
add IDE configs to ignore (.vscode + .idea)
MatousMarik Sep 16, 2024
b65a255
add editor configs
MatousMarik Sep 16, 2024
cb2a596
standardize eslintrc across templates
MatousMarik Sep 16, 2024
e79e1f2
add eslint config and dev dependencies
MatousMarik Sep 16, 2024
0aed5fe
remove duplicate option
MatousMarik Sep 16, 2024
0282754
fix eslint problem (possibly undefined)
MatousMarik Sep 16, 2024
363689d
change typescript-eslint version according to https://github.com/apif…
MatousMarik Sep 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions templates/ts-bootstrap-cheerio-crawler/.dockerignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
# configurations
.idea
.vscode

# crawlee and apify storage folders
storage
Expand Down
18 changes: 17 additions & 1 deletion templates/ts-bootstrap-cheerio-crawler/.eslintrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,20 @@
{
"root": true,
"extends": "@apify/eslint-config-ts"
"env": {
"browser": true,
"es2020": true,
"node": true
},
"extends": [
"@apify/eslint-config-ts"
],
"parserOptions": {
"project": "./tsconfig.json",
"ecmaVersion": 2020
},
"ignorePatterns": [
"node_modules",
"dist",
"**/*.d.ts"
]
}
1 change: 1 addition & 0 deletions templates/ts-bootstrap-cheerio-crawler/.gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

.DS_Store
.idea
.vscode
dist
node_modules
storage
4 changes: 2 additions & 2 deletions templates/ts-bootstrap-cheerio-crawler/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@
"devDependencies": {
"@apify/eslint-config-ts": "^0.3.0",
"@apify/tsconfig": "^0.1.0",
"@typescript-eslint/eslint-plugin": "^6.7.2",
"@typescript-eslint/parser": "^6.7.2",
"@typescript-eslint/eslint-plugin": "^7.18.0",
"@typescript-eslint/parser": "^7.18.0",
"eslint": "^8.50.0",
"tsx": "^4.6.2",
"typescript": "^5.3.3"
Expand Down
1 change: 0 additions & 1 deletion templates/ts-bootstrap-cheerio-crawler/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
{
"extends": "@apify/tsconfig",
"compilerOptions": {
"moduleResolution": "Node",
"module": "NodeNext",
"moduleResolution": "NodeNext",
"target": "ES2022",
Expand Down
1 change: 1 addition & 0 deletions templates/ts-crawlee-cheerio/.dockerignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
# configurations
.idea
.vscode

# crawlee and apify storage folders
apify_storage
Expand Down
1 change: 1 addition & 0 deletions templates/ts-crawlee-cheerio/.gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

.DS_Store
.idea
.vscode
dist
node_modules
apify_storage
Expand Down
4 changes: 2 additions & 2 deletions templates/ts-crawlee-cheerio/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@
"devDependencies": {
"@apify/eslint-config-ts": "^0.3.0",
"@apify/tsconfig": "^0.1.0",
"@typescript-eslint/eslint-plugin": "^6.7.2",
"@typescript-eslint/parser": "^6.7.2",
"@typescript-eslint/eslint-plugin": "^7.18.0",
"@typescript-eslint/parser": "^7.18.0",
"eslint": "^8.50.0",
"tsx": "^4.6.2",
"typescript": "^5.3.3"
Expand Down
1 change: 1 addition & 0 deletions templates/ts-crawlee-playwright-chrome/.dockerignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
# configurations
.idea
.vscode

# crawlee and apify storage folders
apify_storage
Expand Down
1 change: 1 addition & 0 deletions templates/ts-crawlee-playwright-chrome/.gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

.DS_Store
.idea
.vscode
dist
node_modules
apify_storage
Expand Down
4 changes: 2 additions & 2 deletions templates/ts-crawlee-playwright-chrome/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@
"devDependencies": {
"@apify/eslint-config-ts": "^0.3.0",
"@apify/tsconfig": "^0.1.0",
"@typescript-eslint/eslint-plugin": "^6.7.2",
"@typescript-eslint/parser": "^6.7.2",
"@typescript-eslint/eslint-plugin": "^7.18.0",
"@typescript-eslint/parser": "^7.18.0",
"eslint": "^8.50.0",
"tsx": "^4.6.2",
"typescript": "^5.3.3"
Expand Down
1 change: 1 addition & 0 deletions templates/ts-crawlee-puppeteer-chrome/.dockerignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
# configurations
.idea
.vscode

# crawlee and apify storage folders
apify_storage
Expand Down
1 change: 1 addition & 0 deletions templates/ts-crawlee-puppeteer-chrome/.gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

.DS_Store
.idea
.vscode
dist
node_modules
apify_storage
Expand Down
4 changes: 2 additions & 2 deletions templates/ts-crawlee-puppeteer-chrome/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@
"devDependencies": {
"@apify/eslint-config-ts": "^0.3.0",
"@apify/tsconfig": "^0.1.0",
"@typescript-eslint/eslint-plugin": "^6.7.2",
"@typescript-eslint/parser": "^6.7.2",
"@typescript-eslint/eslint-plugin": "^7.18.0",
"@typescript-eslint/parser": "^7.18.0",
"eslint": "^8.50.0",
"tsx": "^4.6.2",
"typescript": "^5.3.3"
Expand Down
1 change: 1 addition & 0 deletions templates/ts-empty/.dockerignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
# configurations
.idea
.vscode

# crawlee and apify storage folders
apify_storage
Expand Down
9 changes: 9 additions & 0 deletions templates/ts-empty/.editorconfig
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
root = true

[*]
indent_style = space
indent_size = 4
charset = utf-8
trim_trailing_whitespace = true
insert_final_newline = true
end_of_line = lf
20 changes: 20 additions & 0 deletions templates/ts-empty/.eslintrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
{
"root": true,
"env": {
"browser": true,
"es2020": true,
"node": true
},
"extends": [
"@apify/eslint-config-ts"
],
"parserOptions": {
"project": "./tsconfig.json",
"ecmaVersion": 2020
},
"ignorePatterns": [
"node_modules",
"dist",
"**/*.d.ts"
]
}
4 changes: 4 additions & 0 deletions templates/ts-empty/.gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
# This file tells Git which files shouldn't be added to source control

.idea
.vscode
storage
apify_storage
crawlee_storage
Expand Down
4 changes: 4 additions & 0 deletions templates/ts-empty/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,11 @@
"crawlee": "^3.5.4"
},
"devDependencies": {
"@apify/eslint-config-ts": "^0.3.0",
"@apify/tsconfig": "^0.1.0",
"@typescript-eslint/eslint-plugin": "^7.18.0",
"@typescript-eslint/parser": "^7.18.0",
"eslint": "^8.50.0",
"tsx": "^4.6.2",
"typescript": "^5.3.3"
},
Expand Down
1 change: 1 addition & 0 deletions templates/ts-playwright-test-runner/.dockerignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
# configurations
.idea
.vscode

# crawlee and apify storage folders
apify_storage
Expand Down
9 changes: 9 additions & 0 deletions templates/ts-playwright-test-runner/.editorconfig
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
root = true

[*]
indent_style = space
indent_size = 4
charset = utf-8
trim_trailing_whitespace = true
insert_final_newline = true
end_of_line = lf
4 changes: 4 additions & 0 deletions templates/ts-playwright-test-runner/.gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
# This file tells Git which files shouldn't be added to source control

.idea
.vscode
storage
node_modules
dist
Expand Down
1 change: 1 addition & 0 deletions templates/ts-standby/.dockerignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
# configurations
.idea
.vscode

# crawlee and apify storage folders
apify_storage
Expand Down
9 changes: 9 additions & 0 deletions templates/ts-standby/.editorconfig
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
root = true

[*]
indent_style = space
indent_size = 4
charset = utf-8
trim_trailing_whitespace = true
insert_final_newline = true
end_of_line = lf
20 changes: 20 additions & 0 deletions templates/ts-standby/.eslintrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
{
"root": true,
"env": {
"browser": true,
"es2020": true,
"node": true
},
"extends": [
"@apify/eslint-config-ts"
],
"parserOptions": {
"project": "./tsconfig.json",
"ecmaVersion": 2020
},
"ignorePatterns": [
"node_modules",
"dist",
"**/*.d.ts"
]
}
4 changes: 4 additions & 0 deletions templates/ts-standby/.gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
# This file tells Git which files shouldn't be added to source control

.idea
.vscode
storage
apify_storage
crawlee_storage
Expand Down
4 changes: 4 additions & 0 deletions templates/ts-standby/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,11 @@
"apify": "^3.1.10"
},
"devDependencies": {
"@apify/eslint-config-ts": "^0.3.0",
"@apify/tsconfig": "^0.1.0",
"@typescript-eslint/eslint-plugin": "^7.18.0",
"@typescript-eslint/parser": "^7.18.0",
"eslint": "^8.50.0",
"tsx": "^4.6.2",
"typescript": "^5.3.3"
},
Expand Down
1 change: 1 addition & 0 deletions templates/ts-start-bun/.dockerignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
# configurations
.idea
.vscode

# crawlee and apify storage folders
apify_storage
Expand Down
9 changes: 9 additions & 0 deletions templates/ts-start-bun/.editorconfig
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
root = true

[*]
indent_style = space
indent_size = 4
charset = utf-8
trim_trailing_whitespace = true
insert_final_newline = true
end_of_line = lf
20 changes: 20 additions & 0 deletions templates/ts-start-bun/.eslintrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
{
"root": true,
"env": {
"browser": true,
"es2020": true,
"node": true
},
"extends": [
"@apify/eslint-config-ts"
],
"parserOptions": {
"project": "./tsconfig.json",
"ecmaVersion": 2020
},
"ignorePatterns": [
"node_modules",
"dist",
"**/*.d.ts"
]
}
4 changes: 4 additions & 0 deletions templates/ts-start-bun/.gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
# This file tells Git which files shouldn't be added to source control

.idea
.vscode
storage
apify_storage
crawlee_storage
Expand Down
8 changes: 7 additions & 1 deletion templates/ts-start-bun/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,13 @@
"cheerio": "^1.0.0-rc.12"
},
"devDependencies": {
"@apify/tsconfig": "^0.1.0"
"@apify/eslint-config-ts": "^0.3.0",
"@apify/tsconfig": "^0.1.0",
"@typescript-eslint/eslint-plugin": "^7.18.0",
"@typescript-eslint/parser": "^7.18.0",
"eslint": "^8.50.0",
"tsx": "^4.6.2",
"typescript": "^5.3.3"
},
"scripts": {
"start": "bun src/main.ts",
Expand Down
2 changes: 1 addition & 1 deletion templates/ts-start-bun/src/main.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ const $ = cheerio.load(response.data);
const headings: { level: string, text: string }[] = [];
$("h1, h2, h3, h4, h5, h6").each((_i, element) => {
const headingObject = {
level: $(element).prop("tagName").toLowerCase(),
level: $(element).prop("tagName")!.toLowerCase(),
text: $(element).text(),
};
console.log("Extracted heading", headingObject);
Expand Down
1 change: 1 addition & 0 deletions templates/ts-start/.dockerignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
# configurations
.idea
.vscode

# crawlee and apify storage folders
apify_storage
Expand Down
9 changes: 9 additions & 0 deletions templates/ts-start/.editorconfig
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
root = true

[*]
indent_style = space
indent_size = 4
charset = utf-8
trim_trailing_whitespace = true
insert_final_newline = true
end_of_line = lf
20 changes: 20 additions & 0 deletions templates/ts-start/.eslintrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
{
"root": true,
"env": {
"browser": true,
"es2020": true,
"node": true
},
"extends": [
"@apify/eslint-config-ts"
],
"parserOptions": {
"project": "./tsconfig.json",
"ecmaVersion": 2020
},
"ignorePatterns": [
"node_modules",
"dist",
"**/*.d.ts"
]
}
4 changes: 4 additions & 0 deletions templates/ts-start/.gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
# This file tells Git which files shouldn't be added to source control

.idea
.vscode
storage
apify_storage
crawlee_storage
Expand Down
Loading
Loading