feat: Add KeyValueStoreClient(Async).get_record_public_url
#506
+170
−43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
t-tooling
barjin
approved these changes
Sep 29, 2025
Comment on lines
90
to
93
| expected_signature = f'?signature={public_url.split("signature=")[1]}' if signing_key else '' | ||
| assert public_url == ( | ||
| f'{(api_public_url or DEFAULT_API_URL).strip("/")}/v2/key-value-stores/someID/keys{expected_signature}' | ||
| ) |
There was a problem hiding this comment.
In all the (new) tests, it seems we're parsing the signature query param from the public_url, only to test if public_url contains this query param.
something like
const { signature } = public_url;
assert public_url === `abc.def/${signature}`;
Can we check whether, e.g., the signature is the actual HMAC of the key instead?
There was a problem hiding this comment.
Added expected signature value to the tests
Pijukatel
force-pushed
the
generating-presigned-url
branch
from
a6f448a to
e1bfec3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
KeyValueStoreClient.get_record_public_url.KeyValueStoreClientAsync.get_record_public_url.Issues
Closes: #497