Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: remove unit-tests, adapt github workflows #4

Merged
merged 6 commits into from
Jul 26, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 0 additions & 31 deletions .github/workflows/_unit_tests.yaml

This file was deleted.

4 changes: 0 additions & 4 deletions .github/workflows/run_code_checks.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,3 @@ jobs:
run_type_checking:
name: Run type checking
uses: ./.github/workflows/_type_checking.yaml

run_unit_tests:
name: Run unit tests
uses: ./.github/workflows/_unit_tests.yaml
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,3 +3,4 @@
## [0.0.1](https://github.com/apify/apify-haystack/releases/tag/v0.0.1) (2024-07-25)

- Dummy package `apify-haystack` was released on PyPI.
- Added CI
8 changes: 3 additions & 5 deletions Makefile
Original file line number Diff line number Diff line change
@@ -1,9 +1,7 @@
.PHONY: clean install-dev build publish-to-pypi lint type-check unit-tests unit-tests-cov integration-tests check-code format check-version-conflict check-changelog-entry check-code build-api-reference run-doc
.PHONY: clean install-dev build publish-to-pypi lint type-check check-code format check-version-conflict check-changelog-entry check-code build-api-reference run-doc

DIRS_WITH_CODE = src tests
DIRS_WITH_CODE = src

# This is default for local testing, but GitHub workflows override it to a higher value in CI
INTEGRATION_TESTS_CONCURRENCY = 1

clean:
rm -rf .mypy_cache .pytest_cache .ruff_cache build dist htmlcov .coverage
Expand Down Expand Up @@ -33,4 +31,4 @@ format:
poetry run ruff check --fix $(DIRS_WITH_CODE)
poetry run ruff format $(DIRS_WITH_CODE)

check-code: lint type-check unit-tests
check-code: lint type-check
4 changes: 2 additions & 2 deletions poetry.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@ max-branches = 18
[tool.mypy]
python_version = "3.9"
plugins = []
files = ["scripts", "src", "tests"]
files = ["src"]
check_untyped_defs = true
disallow_incomplete_defs = true
disallow_untyped_calls = true
Expand Down
Empty file removed tests/__init__.py
Empty file.
Loading