Fix issue with querying request queue head multiple times in parallel #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fnesveda
added
t-platform
jirimoravcik
approved these changes
Aug 31, 2023
This was referenced Aug 31, 2023
Closed
fnesveda
added
the
validated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When calling
_ensure_head_is_non_emptyonRequestQueue, the call to query the RQ head is cached (as an optimization) so that multiple parallel calls to the storage are not made, and in each call of_ensure_head_is_non_emptythe cached call is then awaited.In Python (unlike JavaScript), you can't await the result of an async function multiple times, it leads to an error. To get around that, you can wrap the result of the coroutine into an
asyncio.Task, and that you can await multiple times (asyncio.Taskbehaves sort of like a JSPromisein this regard).