Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor!: RequestQueue and service management rehaul #429

Merged
merged 10 commits into from
Aug 22, 2024
Merged

refactor!: RequestQueue and service management rehaul #429

merged 10 commits into from
Aug 22, 2024

Conversation

janbuchar
Copy link
Collaborator

@janbuchar janbuchar commented Aug 13, 2024 •
edited
Loading

@janbuchar janbuchar added the t-tooling Issues with this label are in the ownership of the tooling team. label Aug 13, 2024
@janbuchar janbuchar requested review from vdusek and B4nan August 13, 2024 17:32
@github-actions github-actions bot added this to the 96th sprint - Tooling team milestone Aug 13, 2024
@github-actions github-actions bot added the tested Temporary label used only programatically for some analytics. label Aug 14, 2024
@janbuchar janbuchar changed the title refactor: RequestQueue rehaul refactor!: RequestQueue and service management rehaul Aug 15, 2024
@janbuchar janbuchar marked this pull request as ready for review August 15, 2024 13:19
vdusek
vdusek requested changes Aug 20, 2024
View reviewed changes
Copy link
Collaborator

@vdusek vdusek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! Just a few minor notes...

src/crawlee/basic_crawler/basic_crawler.py Outdated Show resolved Hide resolved
src/crawlee/service_container.py Outdated Show resolved Hide resolved
src/crawlee/service_container.py Show resolved Hide resolved
src/crawlee/service_container.py Show resolved Hide resolved
src/crawlee/base_storage_client/base_request_queue_client.py Show resolved Hide resolved
src/crawlee/storages/request_queue.py Show resolved Hide resolved
src/crawlee/storages/request_queue.py Outdated Show resolved Hide resolved
janbuchar and others added 4 commits August 22, 2024 10:42
@janbuchar @vdusek
Update src/crawlee/service_container.py
5cefd2d 
Co-authored-by: Vlada Dusek <v.dusek96@gmail.com>
@janbuchar @vdusek
Update src/crawlee/storages/request_queue.py
3766f97 
Co-authored-by: Vlada Dusek <v.dusek96@gmail.com>
@janbuchar
Change import
1066131
@janbuchar
Add service container tests
bfac679
@janbuchar janbuchar requested a review from vdusek August 22, 2024 09:44
vdusek
vdusek approved these changes Aug 22, 2024
View reviewed changes
Copy link
Collaborator

@vdusek vdusek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@janbuchar janbuchar merged commit b155a9f into master Aug 22, 2024
19 checks passed
@janbuchar janbuchar deleted the rqv2 branch August 22, 2024 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vdusek vdusek vdusek approved these changes

@B4nan B4nan Awaiting requested review from B4nan

Assignees

@janbuchar janbuchar

Labels
t-tooling Issues with this label are in the ownership of the tooling team. tested Temporary label used only programatically for some analytics.
Projects
None yet
Milestone
96th sprint - Tooling team
2 participants
@janbuchar @vdusek