-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add pre_navigation_hooks
to PlaywrightCrawler
#631
Conversation
e9366b3
to
1cbf7a8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very cool! Could you please add a test of the functionality as well? Also, some documentation would be great, if you have the time.
1cbf7a8
to
2e3246e
Compare
I have added a test and made the suggested changes. @janbuchar
What type of documentation needs to be added? Will it be an example or a guide or something else? |
Just extending the PlaywrightCrawler example should be enough for now. |
2e3246e
to
8175cca
Compare
Documentation is updated. @janbuchar |
preNavigationHooks
to PlaywrightCrawler
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost there!
preNavigationHooks
to PlaywrightCrawler
pre_navigation_hooks
to PlaywrightCrawler
8175cca
to
c9fa9ab
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!
Description
Add a new decorator for processing pre navigation hooks
Example Use:
Issues
preNavigationHooks
in Playwright #427Checklist