Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use native impit streaming #2833

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

feat: use native impit streaming #2833

wants to merge 1 commit into from

Conversation

barjin
Copy link
Contributor

@barjin barjin commented Feb 8, 2025

Bumps the impit dependency and required Node version for the @crawlee/impit-client package. Makes use of the new native ReadableStream interface.

@barjin barjin self-assigned this Feb 8, 2025
@github-actions github-actions bot added this to the 107th sprint - Tooling team milestone Feb 8, 2025
@github-actions github-actions bot added the t-tooling Issues with this label are in the ownership of the tooling team. label Feb 8, 2025
@barjin
Copy link
Contributor Author

barjin commented Feb 8, 2025

The initial implementation shows slight discrepancies in the types exported from the impit package, requiring awkward casts on this side.

Those problems should be fixed in impit while we still can make "breaking" changes in the API there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@barjin barjin

Labels
t-tooling Issues with this label are in the ownership of the tooling team.
Projects
None yet
Milestone
107th sprint - Tooling team
Development

Successfully merging this pull request may close these issues.
1 participant
@barjin