Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changes how peggy is invoked on postinstall #408

Merged
merged 1 commit into from
Jan 8, 2024

Conversation

gislikonrad
Copy link
Contributor

@gislikonrad gislikonrad commented Dec 8, 2023

The postinstall script was attempting to invoke peggy from the node_modules folder directly. This works fine when manually running the postinstall script from the apigeelint repo, but fails when the package is being installed from npm.

I changed the invocation from invoking peggy directly to using npx.

Solves issue #407

@ssvaidyanathan ssvaidyanathan merged commit 0691b9a into apigee:main Jan 8, 2024
3 checks passed
@ssvaidyanathan
Copy link
Collaborator

@gislikonrad - I get the following error when I try to install apigeelint globally on my machine using sudo npm i apigeelint -g

The error is

npm ERR! > npx mkdirp build && npx peggy -o build/ConditionParser.js lib/peggy/Apigee-Condition.pegjs
npm ERR! sh: mkdirp: command not found

@ssvaidyanathan
Copy link
Collaborator

update - I had to install peggy and mkdirp globally to install apigeelint globally

sudo npm install peggy mkdirp -g

and then
sudo npm install apigeelint -g worked

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants