Merge pull request #12 from apivideo/analytics-v2

Fix custom parameters
apivideo · Jul 30, 2024 · a95f2f9 · a95f2f9
2 parents 75f865d + 6106366
commit a95f2f9
Show file tree

Hide file tree

Showing 5 changed files with 16 additions and 10 deletions.
diff --git a/.npmignore b/.npmignore
@@ -6,3 +6,5 @@ test
 dist/test
 samples/
 .github/
+index.ts
+jest.config.js
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,6 +2,10 @@
 
 All changes to this project will be documented in this file.
 
+## [2.0.1] - 2024-07-31
+
+- Fix custom parameters
+
 ## [2.0.0] - 2024-07-31
 
 - Switch to api.video analytics v2.0

diff --git a/index.ts b/index.ts
@@ -36,13 +36,6 @@ export class VideoJsApiVideoAnalytics extends Plugin {
             (this.options as any).mediaUrl = src;
             this.setOptions(this.options);
             this.lastMediaUrl = src;
-
-            const videoElt = this.player.el().querySelector("video");
-            if (videoElt) {
-              this.playerAnalytics.ovbserveMedia(videoElt);
-            } else {
-              console.error("No video element found in the player");
-            }
           }
         } else {
           this.passthrough = true;
@@ -60,6 +53,13 @@ export class VideoJsApiVideoAnalytics extends Plugin {
       ...options,
     });
 
+    const videoElt = this.player.el().querySelector("video");
+    if (videoElt) {
+      this.playerAnalytics.ovbserveMedia(videoElt);
+    } else {
+      console.error("No video element found in the player");
+    }
+
     this.player.ready(() => {
       if (this.isFirstInit) {
         events.forEach((eventName) =>

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@api.video/videojs-player-analytics",
-  "version": "2.0.0",
+  "version": "2.0.1",
   "description": "api.video player analytics plugin for videojs",
   "repository": {
     "type": "git",