Add code examples showing the need for synchronization#344
Open
Add code examples showing the need for synchronization#344
Conversation
f79d447 to
158b338
Compare
Codecov Report
@@ Coverage Diff @@
## master #344 +/- ##
=========================================
Coverage 58.96% 58.96%
Complexity 1128 1128
=========================================
Files 233 233
Lines 9094 9094
Branches 1362 1362
=========================================
Hits 5362 5362
Misses 3468 3468
Partials 264 264 Continue to review full report at Codecov.
|
158b338 to
34b043d
Compare
34b043d to
d1d6dd2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
PickANumberexample demonstrates a bug in the compiler. The problem isn't with synchronization, however. It is to do with wheredeclassifyoperations are performed. An operationlet y = declassify x to lmust be placed on a protocol that can readx, but we only require that it is placed on a protocol that can ready. This is a strictly bigger set of protocols, and causes certain values to be reveal before they should.