Implementation of Commitment Protocol backend for Viaduct 2.0 (Circuit IR)#795
Open
adityanathan wants to merge 15 commits intomasterfrom
Open
Implementation of Commitment Protocol backend for Viaduct 2.0 (Circuit IR)#795adityanathan wants to merge 15 commits intomasterfrom
adityanathan wants to merge 15 commits intomasterfrom
Conversation
…rors and test errors.
…input-output files for example1.circuit
…rotocol circuit backend
… appropriate exceptions for commitments
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #795 +/- ##
============================================
+ Coverage 65.66% 65.77% +0.11%
- Complexity 1319 1338 +19
============================================
Files 258 259 +1
Lines 11018 11127 +109
Branches 1599 1618 +19
============================================
+ Hits 7235 7319 +84
- Misses 3470 3480 +10
- Partials 313 328 +15 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cacay
reviewed
Sep 14, 2024
Member
cacay
left a comment
cacay
left a comment
There was a problem hiding this comment.
Some style comments and one significant one about security.
...in/kotlin/io/github/aplcornell/viaduct/backends/commitment/CommitmentCircuitCodeGenerator.kt
Show resolved
Hide resolved
...in/kotlin/io/github/aplcornell/viaduct/backends/commitment/CommitmentCircuitCodeGenerator.kt
Show resolved
Hide resolved
| * This is because the commitment protocol is only a storage format and not a computation protocol. | ||
| */ | ||
| class CommitmentCircuitCodeGenerator(context: CodeGeneratorContext) : AbstractCodeGenerator(context) { | ||
| override fun paramType(protocol: Protocol, sourceType: ValueType): TypeName { |
Member
There was a problem hiding this comment.
I think this code belongs under storageType. paramType should be undefined (throw an error).
...main/kotlin/io/github/aplcornell/viaduct/backends/cleartext/CleartextCircuitCodeGenerator.kt
Outdated
Show resolved
Hide resolved
...main/kotlin/io/github/aplcornell/viaduct/backends/cleartext/CleartextCircuitCodeGenerator.kt
Outdated
Show resolved
Hide resolved
...main/kotlin/io/github/aplcornell/viaduct/backends/cleartext/CleartextCircuitCodeGenerator.kt
Outdated
Show resolved
Hide resolved
...main/kotlin/io/github/aplcornell/viaduct/backends/cleartext/CleartextCircuitCodeGenerator.kt
Outdated
Show resolved
Hide resolved
...main/kotlin/io/github/aplcornell/viaduct/backends/cleartext/CleartextCircuitCodeGenerator.kt
Outdated
Show resolved
Hide resolved
...main/kotlin/io/github/aplcornell/viaduct/backends/cleartext/CleartextCircuitCodeGenerator.kt
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.