FIXUP refactoring coursemodulepermission

course/permissions.py

@@ -15,15 +15,14 @@
     FilterBackend,
 )
 from exercise.cache.points import CachedPoints
-from exercise.models import BaseExercise
+from exercise.models import BaseExercise, LearningObject
 from exercise.submission_models import Submission
 from userprofile.models import GraderUser, UserProfile
 from .models import (
     Course,
     CourseModule,
     CourseInstance,
 )
-from exercise.models import LearningObject
 
 
 class JWTObjectPermission(Permission):
@@ -249,12 +248,14 @@ def has_object_permission(self, request: HttpRequest, view: Any, module: CourseM
         if module.status == CourseModule.STATUS.HIDDEN:
             return False
 
-        #if this isn't an enrollment question and the module hasn't opened yet
-        if (
-            not (hasattr(view, 'exercise')
-            and view.exercise.status in (LearningObject.STATUS.ENROLLMENT, LearningObject.STATUS.ENROLLMENT_EXTERNAL))
-            and not module.is_after_open()
-        ):
+        # Enrollment questionnaires are not affected by the module opening time.
+        if hasattr(view, 'exercise') and view.exercise.status in (
+                LearningObject.STATUS.ENROLLMENT,
+                LearningObject.STATUS.ENROLLMENT_EXTERNAL,
+                ):
+            return True
+
+        if not module.is_after_open():
             # FIXME: use format from django settings
             self.error_msg(
                 _('MODULE_PERMISSION_ERROR_NOT_OPEN_YET -- {date}'),