Code Quality Improvements - Memq Actor Module#24
Merged
santanusinha merged 2 commits intoappform-io:masterfrom Jan 13, 2026
Merged
Code Quality Improvements - Memq Actor Module#24santanusinha merged 2 commits intoappform-io:masterfrom
santanusinha merged 2 commits intoappform-io:masterfrom
Conversation
Changes Made: Refactored Nested Ternary to If-Else (ActorSystem.java) Extracted nested ternary in partitioner() method into clear if-else statements Improved readability and maintainability Renamed Generic Type Parameter (HighLevelActor.java) Changed MessageType → T to comply with Java naming convention ^[A-Z][0-9]?$ Updated class declaration and all constructor signatures Refactored to BiPredicate (Actor.java, ActorSystem.java) Replaced BiFunction<M, MessageMeta, Boolean> → BiPredicate<M, MessageMeta> Updated validationHandler and consumerHandler fields and parameters Changed method calls from .apply() → .test() Better semantic clarity and type safety Added No-Op Comments Actor.java: Switch block explanation and ASYNC_ISOLATED no-op comment SyncDispatcher.java: close() method no-op comment TerminalActorObserver.java: initialize() method no-op comment MemQTestExtension.java: beforeEach() method no-op comment Version Bump Reason: Breaking API change in Actor constructor signature Impact: BiFunction → BiPredicate requires callers to update their code
santanusinha
approved these changes
Jan 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Version Bump
Reason: Breaking API change in Actor constructor signature Impact: BiFunction → BiPredicate requires callers to update their code
Changes Made:
Refactored Nested Ternary to If-Else (ActorSystem.java)
Extracted nested ternary in partitioner() method into clear if-else statements Improved readability and maintainability
Renamed Generic Type Parameter (HighLevelActor.java)
Changed MessageType → T to comply with Java naming convention ^[A-Z][0-9]?$ Updated class declaration and all constructor signatures Refactored to BiPredicate (Actor.java, ActorSystem.java)
Replaced BiFunction<M, MessageMeta, Boolean> → BiPredicate<M, MessageMeta> Updated validationHandler and consumerHandler fields and parameters Changed method calls from .apply() → .test()
Better semantic clarity and type safety
Added No-Op Comments
Actor.java: Switch block explanation and ASYNC_ISOLATED no-op comment
SyncDispatcher.java: close() method no-op comment
TerminalActorObserver.java: initialize() method no-op comment
MemQTestExtension.java: beforeEach() method no-op comment