forked from facebookarchive/WebDriverAgent
-
Notifications
You must be signed in to change notification settings - Fork 445
fix: make runUntilDate not system aware #1050
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
codeskyblue
wants to merge
8
commits into
appium:master
Choose a base branch
from
codeskyblue:fix_stuck_when_system_time_changes
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
f86edc7
make runUntilDate not system aware
codeskyblue 8826443
Update NSRunLoop+Monotonic.m
codeskyblue cbad468
update all the runUntilDate
codeskyblue 43adc5a
Merge branch 'fix_stuck_when_system_time_changes' of https://github.c…
codeskyblue c9bf35a
add docstring
KazuCocoa 4e79777
Use NSRunLoopCommonModes instead
KazuCocoa 67064ed
Merge branch 'master' into fix_stuck_when_system_time_changes
KazuCocoa 26c1059
add docstring
codeskyblue File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
#import <Foundation/Foundation.h> | ||
|
||
@interface NSRunLoop (Monotonic) | ||
/** | ||
Runs the current run loop in the default mode for the specified monotonic time interval. | ||
|
||
This method uses a monotonic clock to ensure the interval is not affected | ||
by changes to the system clock. The run loop will repeatedly process events | ||
until the given number of seconds has elapsed. | ||
|
||
@param seconds The duration, in seconds, to run the run loop. | ||
*/ | ||
- (void)runForMonotonicInterval:(NSTimeInterval)seconds; | ||
KazuCocoa marked this conversation as resolved.
Show resolved
Hide resolved
|
||
@end |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
#import "NSRunLoop+Monotonic.h" | ||
#import <QuartzCore/QuartzCore.h> | ||
|
||
@implementation NSRunLoop (Monotonic) | ||
|
||
/** | ||
* Runs the current run loop for a specified monotonic interval (in seconds), | ||
* using CACurrentMediaTime for time measurement. This method is not affected by system time changes. | ||
* | ||
* @param seconds The duration to run the run loop, measured in monotonic time. | ||
*/ | ||
- (void)runForMonotonicInterval:(NSTimeInterval)seconds { | ||
CFTimeInterval end = CACurrentMediaTime() + seconds; | ||
while (CACurrentMediaTime() < end) { | ||
[self runMode:NSRunLoopCommonModes beforeDate:[NSDate distantFuture]]; | ||
} | ||
} | ||
|
||
@end |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.