Skip to content

Commit

Permalink
fix: increase pull recent timeout (#802)
Browse files Browse the repository at this point in the history
Increase timeout of the pull command in pullRecent to 5 minutes.
Videos longer than 30 minutes can take over 60s to pull.

Fixes: appium/appium#18522
  • Loading branch information
Mohanjith Sudirikku Hannadige authored Apr 18, 2023
1 parent bf0593f commit fd9b8ea
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion lib/commands/media-projection.js
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,8 @@ class MediaProjectionRecorder {
}

const dstPath = path.join(await tempDir.openDir(), recordings[0]);
await this.adb.pull(`${RECORDINGS_ROOT}/${recordings[0]}`, dstPath);
// increase timeout to 5 minutes because it might take a while to pull a large video file
await this.adb.pull(`${RECORDINGS_ROOT}/${recordings[0]}`, dstPath, {timeout: 300000});
return dstPath;
}

Expand Down

0 comments on commit fd9b8ea

Please sign in to comment.