Skip to content

Commit

Permalink
chore(deps): upgrade Electron to 31.4.0 (#1659)
Browse files Browse the repository at this point in the history
* chore(deps): update electron to 32.0.2

* chore(deps): downgrade electron to v31
there are known issues on x64 Macs

* fix: adjust macOS draggable regions for Electron 23

* docs: update system requirements

* fix: adjust more macOS draggable regions
  • Loading branch information
eglitise authored Sep 6, 2024
1 parent 192a14b commit a26c3b3
Show file tree
Hide file tree
Showing 8 changed files with 156 additions and 929 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,7 @@
width: auto !important;
}

.inspector-toolbar button {
border-color: #cacaca;
.inspector-toolbar :global(.ant-space-item) {
-webkit-app-region: no-drag;
}

Expand Down Expand Up @@ -52,7 +51,6 @@
width: 100%;
height: 38px;
margin-bottom: 12px;
-webkit-app-region: drag;
}

.inspector-main .screenshot-container img {
Expand Down
4 changes: 4 additions & 0 deletions app/common/renderer/components/Session/Session.module.css
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,10 @@
-webkit-app-region: drag;
}

.serverTabs :global(.ant-tabs-tab) {
-webkit-app-region: no-drag;
}

.serverTabs :global(.ant-form > .ant-row > div) {
padding-bottom: 12px;
}
Expand Down
1 change: 0 additions & 1 deletion app/electron/main/windows.js
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,6 @@ function buildSessionWindow() {
sandbox: false,
nodeIntegration: true,
contextIsolation: false,
enableRemoteModule: true,
additionalArguments: openFilePath ? [`filename=${openFilePath}`] : [],
},
});
Expand Down
11 changes: 8 additions & 3 deletions docs/quickstart/requirements.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,15 @@ title: System Requirements
Since the Inspector has two versions, [a desktop app and a web app](../overview.md#formats), the
requirements for these will differ.

- The web app supports Chrome and Firefox browsers
([Safari is not supported](../troubleshooting.md#browser-version-does-not-work-in-safari))
- Web app
- Works in Chrome/Edge/Firefox, released September 2021 or later
([Safari is not supported](../troubleshooting.md#browser-version-does-not-work-in-safari))
- Viewport size of at least **870 x 610** pixels is recommended
- The desktop app requires up to around **600MB** of space on the computer
- Desktop app
- Works on Windows 10+, macOS 10.15+, Ubuntu 18.04+, Debian 10+, openSUSE 15.5+, or Fedora Linux 39+
- [These requirements are taken from Chrome](https://support.google.com/chrome/a/answer/7100626),
as the Inspector is built using Electron (which uses Chromium)
- Up to around **600MB** of free space is required
- The minimum application window size is **890 x 710** pixels

Both Inspector versions also require an **Appium server** to connect to, which is _not_ bundled with
Expand Down
2 changes: 1 addition & 1 deletion docs/troubleshooting.md
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ create a session.
## Browser version does not work in Safari

This is [a known issue](https://github.com/appium/appium-inspector/issues/103). Currently it is
advised to use Chrome or Firefox instead.
advised to use Chrome, Edge or Firefox instead.

## Start Session button is cut off

Expand Down
Loading

0 comments on commit a26c3b3

Please sign in to comment.