Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix missing highlighter key #969

Merged
merged 1 commit into from
Jul 6, 2023

Conversation

eglitise
Copy link
Collaborator

@eglitise eglitise commented Jul 6, 2023

Quick PR to add a key property that React was complaining about.
This key is for a highlighter shown when selecting a found element, so its only properties are its dimensions, and the key must be assembled from all of them in order to be uniquely rendered.

@eglitise eglitise added the chore Internal changes not visible to the user label Jul 6, 2023
@eglitise eglitise merged commit d1c821b into appium:main Jul 6, 2023
4 checks passed
@eglitise eglitise deleted the fix-missing-highlighter-key branch July 6, 2023 16:57
shiva-guntoju pushed a commit to shiva-guntoju/appium-inspector that referenced this pull request Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Internal changes not visible to the user
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant