fix: resolve issue with unwanted incremental scaling in landscape #990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlipps
approved these changes
Jul 19, 2023
KazuCocoa
approved these changes
Jul 20, 2023
shiva-guntoju
pushed a commit
to shiva-guntoju/appium-inspector
that referenced
this pull request
Feb 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a problem I've mainly noticed when working with an app in landscape orientation.
When opening such an app with the default inspector app window dimensions, the screenshot width is around 450 pixels. However, if I refresh the source, the screenshot width slightly increases, and continues increasing until it reaches the max limit of 500 pixels:
old-behavior.mp4
Now, the default screenshot width is a bit smaller at 430 pixels, but it no longer changes upon source refresh:
new-behavior.mp4
Of course, the screenshot size can still be adjusted by changing the app window size.