-
Notifications
You must be signed in to change notification settings - Fork 549
feat: implement version sub command #911
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
jglogan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @fatelei, please have a look at the comments and lmk what you think!
Also for this to be merged you'll need so set up commit signing; see https://github.com/apple/containerization/blob/main/CONTRIBUTING.md#pull-requests for details.
|
Looks like this PR closes #383 |
bfd750e to
e25214c
Compare
jglogan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fatelei Thanks for the updates!
Just a couple of name changes for consistency, and a couple suggestions for simplifying the tabular and JSON presentation.
Type of Change
Motivation and Context
implement version sub command, give more info
Testing