Add content subcommand #917
Open
+363
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Marked as draft for now. Please let me know if this makes sense and what kind of tests you would like to see! |
malt3
force-pushed
the
content_subcommand
branch
from
2eab672 to
2f04d69
Compare
This command can be used to interact with the content store XPC via simple commands.
Since many container tools are written in Go, it's not easy to interact with the XPC service from other tools.
Go has good support for unix domain sockets, but Mach ports (and XPC) are another story.
The content store is very useful to enable incremental image loading.
The closest alternative ("container image load") requires materialization of all blobs in a tar file.
With the content store, we can check which blobs are already available, and only load missing ones.
This will enable faster development workflows in tools like rules_img: https://github.com/bazel-contrib/rules_img.
A similar move is being made in Docker. The containerd content store used to be limited to the containerd socket.
This upstream issue will expose the containerd content store directly via Docker: moby/moby#44369
malt3
force-pushed
the
content_subcommand
branch
from
2f04d69 to
5b7b0b1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Motivation and Context
This command can be used to interact with the content store XPC via simple commands. Since many container tools are written in Go, it's not easy to interact with the XPC service from other tools. Go has good support for unix domain sockets, but Mach ports (and XPC) are another story.
The content store is very useful to enable incremental image loading. The closest alternative ("container image load") requires materialization of all blobs in a tar file. With the content store, we can check which blobs are already available and only load missing ones. This will enable faster development workflows in tools like rules_img: https://github.com/bazel-contrib/rules_img.
A similar move is being made in Docker. The containerd content store used to be limited to the containerd socket. This upstream issue will expose the containerd content store directly via Docker: moby/moby#44369
Testing