Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added DriveThru sites as shared credentials #714

Merged
merged 5 commits into from
Sep 27, 2024
Merged

added DriveThru sites as shared credentials #714

merged 5 commits into from
Sep 27, 2024

Conversation

mpanighetti
Copy link
Contributor

@mpanighetti mpanighetti commented Sep 19, 2023

  • added DriveThru sites as shared credentials (confirmed firsthand that all these sites use a shared account, as they are part of the "DriveThru family of sites")

Overall Checklist

for shared-credentials.json

  • There's evidence the domains are currently related (SSL certificates, DNS entries, valid links between sites, legal documents etc.)
  • If using shared, the new group serves login pages on each of the included domains, and those login pages accept accounts from the others. (For example, we wouldn't use a shared association from google.co.il to google.com, because google.co.il redirects to accounts.google.com for sign in.)

- added DriveThruRPG.com and DMsGuild.com as shared credentials
@rmondello
Copy link
Contributor

Run ruby tools/convert-shared-credential-to-legacy-format.rb --verify
  ruby tools/convert-shared-credential-to-legacy-format.rb --verify
  shell: /usr/bin/bash -e {0}
ERROR: websites-with-shared-credential-backends.json is not up-to-date. Please run this script again and commit the changes.
Error: Process completed with exit code 1.

Please run tools/convert-shared-credential-to-legacy-format.rb and commit the result of that. (Sorry about this! We should automate that somehow.)

- added drivethrucards.com, drivethrucomics.com, drivethrufiction.com, pathfinderinfinite.com, storytellersvault.com, and wargamevault.com to existing shared passwords (alongside drivethrurpg.com and dmsguild.com)
- ran fixer script
@mpanighetti mpanighetti changed the title added DriveThruRPG.com and DMsGuild.com as shared credentials added DriveThru sites as shared credentials Sep 19, 2023
@mpanighetti
Copy link
Contributor Author

Thanks! Added a few more sites to the same shared credential set and ran the fixer script, should be good to test now.

@erynofwales erynofwales merged commit 63180d5 into apple:main Sep 27, 2024
5 checks passed
@mpanighetti mpanighetti deleted the patch-1 branch September 28, 2024 00:35
rmondello pushed a commit to rmondello/password-manager-resources that referenced this pull request Nov 6, 2024
* added DriveThruRPG.com and DMsGuild.com as shared credentials

- added DriveThruRPG.com and DMsGuild.com as shared credentials

* typo correction

* ran script

* added more partner sites

- added drivethrucards.com, drivethrucomics.com, drivethrufiction.com, pathfinderinfinite.com, storytellersvault.com, and wargamevault.com to existing shared passwords (alongside drivethrurpg.com and dmsguild.com)
- ran fixer script

---------

Co-authored-by: Eryn Wells <eryn_wells@apple.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants