Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Yahoo/Flickr relationship #715

Merged
merged 1 commit into from
Oct 17, 2023

Conversation

parkerbxyz
Copy link
Contributor

@parkerbxyz parkerbxyz commented Sep 22, 2023

Flickr no longer shares a credential backend with Yahoo.

Supporting resources:

Overall Checklist

for password-rules.json

  • The given rule isn't particularly standard and obvious for password managers
  • Generated passwords have been tested from this rule using the Password Rules Validation Tool
  • Information has been included about the website's requirements (eg. screenshots, error messages, steps during experimentation, etc.)
  • The PR isn't documenting something that would be a common practice among password managers (e.g. minimal length of 6)

for change-password-URLs.json

  • There is no Well-Known URL for Changing Passwords (https://example.com/.well-known/change-password)
  • The URL either makes the experience better or no worse than being directed to just the domain in a non-logged-in state

for shared-credentials.json

  • There's evidence the domains are currently related (SSL certificates, DNS entries, valid links between sites, legal documents etc.)
  • If using shared, the new group serves login pages on each of the included domains, and those login pages accept accounts from the others. (For example, we wouldn't use a shared association from google.co.il to google.com, because google.co.il redirects to accounts.google.com for sign in.)
  • If using from and to, the new group, the from domain(s) redirect to the to domain to log in.

for shared-credentials-historical.json

  • You believe that the domains were associated at some point in the past and can explain that relationship

Flickr no longer shares a credential backend with Yahoo.
@parkerbxyz parkerbxyz force-pushed the separate-flickr-yahoo branch from 7bd255e to 46dc1e2 Compare September 22, 2023 00:41
@ybron
Copy link

ybron commented Oct 17, 2023

Thank you for this well-documented PR!

@rmondello
Copy link
Contributor

Thank you for the contribution!

@rmondello rmondello merged commit ac895a2 into apple:main Oct 17, 2023
5 checks passed
@parkerbxyz parkerbxyz deleted the separate-flickr-yahoo branch October 19, 2023 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants