Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Activision & callofduty.com share credentials #726

Merged
merged 2 commits into from
Dec 2, 2023

Conversation

ellieayla
Copy link
Contributor

@ellieayla ellieayla commented Dec 1, 2023

Overall Checklist

for password-rules.json

  • The given rule isn't particularly standard and obvious for password managers
  • Generated passwords have been tested from this rule using the Password Rules Validation Tool
  • Information has been included about the website's requirements (eg. screenshots, error messages, steps during experimentation, etc.)
  • The PR isn't documenting something that would be a common practice among password managers (e.g. minimal length of 6)

for change-password-URLs.json

  • There is no Well-Known URL for Changing Passwords (https://example.com/.well-known/change-password)
  • The URL either makes the experience better or no worse than being directed to just the domain in a non-logged-in state

for shared-credentials.json

  • There's evidence the domains are currently related (SSL certificates, DNS entries, valid links between sites, legal documents etc.)
  • If using shared, the new group serves login pages on each of the included domains, and those login pages accept accounts from the others. (For example, we wouldn't use a shared association from google.co.il to google.com, because google.co.il redirects to accounts.google.com for sign in.)
  • If using from and to, the new group, the from domain(s) redirect to the to domain to log in.

for shared-credentials-historical.json

  • You believe that the domains were associated at some point in the past and can explain that relationship

@ellieayla
Copy link
Contributor Author

I'm not sure whether sorting different is required, but otherwise I think this is correct. Feedback appreciated.

@rmondello
Copy link
Contributor

@ellieayla The change does look good to me, but you were right — it's not sorted properly. Would you consider applying the quirk to all of activision.com?

@ellieayla
Copy link
Contributor Author

ellieayla commented Dec 2, 2023

I don't find a login page directly on activision.com anywhere, only on the subdomain. It doesn't seem to make sense being sorted under S (but I think that's what the test demands). C? Dunno.

@rmondello rmondello self-assigned this Dec 2, 2023
@rmondello rmondello merged commit a8ba234 into apple:main Dec 2, 2023
4 of 5 checks passed
@rmondello
Copy link
Contributor

Thanks for the contribution @ellieayla!

@ellieayla ellieayla deleted the patch-1 branch December 3, 2023 02:21
rmondello pushed a commit to rmondello/password-manager-resources that referenced this pull request Dec 15, 2023
* Activision & callofduty.com share credentials

* Sorting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants