Skip to content

Add password rules for vince.com #741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 18, 2024
Merged

Add password rules for vince.com #741

merged 1 commit into from
Jan 18, 2024

Conversation

dmmaslenn
Copy link
Collaborator

This website does not support - special character in password.

Overall Checklist

for password-rules.json

  • The given rule isn't particularly standard and obvious for password managers
  • Generated passwords have been tested from this rule using the Password Rules Validation Tool
  • Information has been included about the website's requirements (eg. screenshots, error messages, steps during experimentation, etc.)
  • The PR isn't documenting something that would be a common practice among password managers (e.g. minimal length of 6)

@@ -782,6 +782,9 @@
"vetsfirstchoice.com": {
"password-rules": "minlength: 8; required: lower; required: upper; required: digit; allowed: [?!@$%^+=&];"
},
"vince.com": {
"password-rules": "minlength: 8; required: digit, lower, upper, [$%/()[]{}=?!.,_*|+~#];"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What your rules says:
Required: one of a { digit, lower, upper, or special character from this set }

What the site says:

Required: 8 Characters
One capital and 1 lowercase letter
At least 1 number
At least one special character $%/()[]{}=?!.,-_*|+~#

Which translates to pseudo-code:

Min-length: 8
Required: digit
Required: lower
Required: upper
Required: one of these: $%/()[]{}=?!.,-_*|+~#

Also, ] is treated specially in our format. It has to be the last character of a character class.

With all of that, I think your rule should be:

minlength: 8; required: digit; required: lower; required: upper; required: [$%/(){}=?!.,_*|+~#[]];

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rmondello Please do not be fooled by what the site visually claims to support. Their JS validates as follows: {length: /\S{8,}/, loweruppercase: /(?=.[A-Z])(?=.[a-z])/, number: /\d/, special: /[$%/()[]{}=?!.,_*|+~#]/}

Please do not put back in the "-" as it won't work.

Copy link
Contributor

@rmondello rmondello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd love to review this with some changes!

@dmmaslenn dmmaslenn force-pushed the password-rules-update branch from ae794a9 to 9cacf27 Compare January 18, 2024 20:02
@rmondello rmondello merged commit e5edf95 into main Jan 18, 2024
@dmmaslenn dmmaslenn deleted the password-rules-update branch January 18, 2024 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants