[DO NOT MERGE] Add BashExpr #197
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weissi
reviewed
Apr 26, 2024
| expr: .error( | ||
| .unexpectedToken( | ||
| "\(children.first), expected .literal($)", | ||
| NSRange(location: 0, length: 0) |
There was a problem hiding this comment.
NSRange is a very strange type for Swift and should be avoided. Range<Int> sounds like the better choice here, right?
There was a problem hiding this comment.
Hmm.. Possibly. The location and length parameters are bogus too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A subset of Bash on top of Swift.
I'm thinking about implementing
[MemoizedBashExpr.swift](https://github.com/apple/swift-llbuild2/compare/bash-expr?expand=1#diff-7095f25a6ac8f1229c6ca185a1ed9557f3453d14705e19d22b085c1c2c4a6503)on top of llbuild2fx keys.I'm not intending to merge this yet because it is introducing new package dependencies to llbuild2.