Skip to content

Conversation

aciidgh
Copy link
Member

@aciidgh aciidgh commented Oct 8, 2025

This will allow clients to distingush streams coming from different spawn processes.

This will allow clients to distingush streams coming from different
spawn processes.
@aciidgh aciidgh requested a review from rballard2 October 8, 2025 16:20
@aciidgh aciidgh requested a review from dmbryson as a code owner October 8, 2025 16:20
@rballard2
Copy link
Contributor

The intended way to distinguish streams from different SpawnProcesses is to pass different stdoutStreamingDestination/stderrStreamingDestination for different invocations. Is there somewhere where this wouldn't work?

@aciidgh
Copy link
Member Author

aciidgh commented Oct 8, 2025

that would also work but it seems less ergonomic to have to specify unique filenames for all clients

@rballard2
Copy link
Contributor

Fair point. How about autogenerating a unique name by default? Something like "\(executable)/\(hash(arguments)).(log|err)" for the output/error logs? That's hopefully a good mix of human-readable and reasonably-unique, and you can still override the log names if you need to.

@aciidgh
Copy link
Member Author

aciidgh commented Oct 8, 2025

That's a good idea but I think we'll still want the spec object because clients will want to know what process is being executed and what were the args.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants