ci: Add missing environment variable to integration-test#641
Merged
simonjbeaumont merged 1 commit intoapple:mainfrom Oct 2, 2024
Merged
ci: Add missing environment variable to integration-test#641simonjbeaumont merged 1 commit intoapple:mainfrom
simonjbeaumont merged 1 commit intoapple:mainfrom
Conversation
50efb28 to
2312177
Compare
2312177 to
ba54fce
Compare
czechboy0
approved these changes
Oct 2, 2024
Contributor
czechboy0
left a comment
There was a problem hiding this comment.
Thanks for spotting and fixing this! 🙏
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
When we migrated the CI to Github Actions we lost an important configuration for the integration test that makes sure we're using the copy of this repo from the PR, rather than cloning from upstream. This can be seen in the logs of recent PR jobs:
This used to be specified in the Docker Compose file as an environment variable but dropped off during migration.
Modifications
Add the environment variable back to use
file://${GITHUB_WORKSPACE}for the clone.Note that one cannot use the
env:map when making use of a reusable GitHub workflow withuses:so it's been added in the command passed to the matrix job, itself.Result
The integration test CI will use this repo for the test itself so we can make sure we're testing the right thing.
Test Plan
The logs on this PR job show that we're now cloning from the GitHub workspace: