e - Added tests to show discrepancies when handling XML output by Jackson.#473
Closed
JCook21 wants to merge 2 commits intoapprovals:masterfrom
Closed
e - Added tests to show discrepancies when handling XML output by Jackson.#473JCook21 wants to merge 2 commits intoapprovals:masterfrom
JCook21 wants to merge 2 commits intoapprovals:masterfrom
Conversation
JCook21
commented
Feb 21, 2024
Author
There was a problem hiding this comment.
I'm not sure why this file is showing as changed, please ignore for the purposes of showing the issue I'm seeing in handling XML.
JCook21
commented
Feb 21, 2024
Author
There was a problem hiding this comment.
I'm not sure why this file is showing as changed, please ignore for the purposes of showing the issue I'm seeing in handling XML.
Member
|
Hey, we're looking into this issue today. Is it still impacting you? |
Author
|
Hey, thanks for checking in on this. This isn't currently affecting me but I suspect the root problem is still there. I think this is ok to close for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added tests to show discrepancies between XML generated by Jackson and that output by
ApprovalXmlWriter.prettyPrint().