Add response status codes to Plug samples #452
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like appsignal/appsignal-ruby#183, but for Elixir. As requested via support (private Intercom link). Opening this pull request instead of an issue since the implementation was mostly done answering their question.
I recommend tagging samples manually until we merge this. That would look something like this;
When using the temporary solution: Some things to note is to update the conn with the result of your render/2 call to make sure the response code is set. Also; don’t forget to return the conn from your action, as Appsignal.Transaction.set_sample_data/2 returns the Appsignal.Transaction struct.