-
Notifications
You must be signed in to change notification settings - Fork 117
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix Padrino instrumentation causing boot loop (#1143)
Apply the same boot loop fix as for Sinatra for Padrino from PR #1105. For Sinatra apps noticed in our test setup that when I added a Sinatra app to the Rails app, and loaded the Sinatra instrumentation as specified in our docs it would get stuck in a boot loop. This was caused by the two different configs overwriting each other every time. Apply the same fix for Padrino by checking first if AppSignal has already started and skipping the auto start.
- Loading branch information
Showing
3 changed files
with
43 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
--- | ||
bump: patch | ||
type: fix | ||
--- | ||
|
||
Fix issue with AppSignal getting stuck in a boot loop when loading the Padrino integration with: `require "appsignal/integrations/padrino"` | ||
This could happen in nested applications, like a Padrino app in a Rails app. AppSignal will now use the first config AppSignal starts with. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters