Support nested Grape apps #1118
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unflxw
approved these changes
Jun 26, 2024
Refactor the Grape middleware to inherit from the AbstractMiddleware class. I've removed the inheritance on the Grape::Middleware::Base. We don't rely on the base Grape middleware. By using an AbstractMiddleware subclass for Grape we support Grape apps nested in Sinatra, Rails and other apps already using AppSignal instrumentation middleware. To keep the `grape.skip_appsignal_error` request env logic to work, I've made the `report_errors` option accept a proc and call it if it's callable to determine per request if the error should be reported.
tombruijn
force-pushed
the
grape-abstract-middleware
branch
from
93a2974 to
718cdc1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support nested Grape apps
Refactor the Grape middleware to inherit from the AbstractMiddleware class. I've removed the inheritance on the Grape::Middleware::Base. We don't rely on the base Grape middleware.
By using an AbstractMiddleware subclass for Grape, we support Grape apps nested in Sinatra, Rails, and other apps already using AppSignal instrumentation middleware.
To keep the
grape.skip_appsignal_errorrequest env logic to work, I've made thereport_errorsoption accept a proc and call it if it's callable to determine per request if the error should be reported.Part of #329