Add Ruby 4.0.0 preview to CI #1478
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ All good! |
Contributor
Author
unflxw
force-pushed
the
ruby-4-preview-ci
branch
from
c8f4582 to
2ea5205
Compare
unflxw
force-pushed
the
ruby-4-preview-ci
branch
from
a89e091 to
9ea1908
Compare
Contributor
Author
|
A deprecation in |
unflxw
force-pushed
the
ruby-4-preview-ci
branch
from
5461345 to
124ee9e
Compare
Run our tests against Ruby's `4.0.0-preview2` on our CI anywhere where we were already running them against `3.5.0-preview1`.
- Use `URI.decode_www_form` instead of `CGI.parse`, which has now been removed, to validate the query string sent by the transmitter. - When testing against Bundler versions that raise an error when `Bundler.rubygems.all_specs` is called, skip the test. This test was already skipped if the method is not implemented. - Use a regular expression to assert the logs content when a `Set` object is rejected by the sample data, accounting for the different output of `Set.inspect` in Ruby 4.
Padrino and Hanami have dependencies that ultimately depend on `bundler < 3`. This makes them incompatible with Ruby 4 for the time being. We should re-assess this after Ruby 4 is released and the affected libraries release the necessary updates.
unflxw
force-pushed
the
ruby-4-preview-ci
branch
from
124ee9e to
eaf056b
Compare
|
Hi @unflxw, We've found new issues for this Pull Request. Please see the main comment on this issue for a list of all current warnings. This comment will not be updated to reflect resolved warnings.
|
tombruijn
approved these changes
Nov 21, 2025
Member
tombruijn
left a comment
tombruijn
left a comment
There was a problem hiding this comment.
I guess Ruby 3.5.0 isn't happening anymore? We have the preview1 in the CI, but if they're going forward with Ruby 4 then we could remove it from our CI, right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[skip changeset] because all changes are to the CI configuration and tests -- no implementation change was made
Add Ruby 4.0.0 preview to CI
Run our tests against Ruby's
4.0.0-preview2on our CI anywherewhere we were already running them against
3.5.0-preview1.Fix test failures in Ruby 4
URI.decode_www_forminstead ofCGI.parse, which has nowbeen removed, to validate the query string sent by the transmitter.
Bundler.rubygems.all_specsis called, skip the test. This testwas already skipped if the method is not implemented.
Setobject is rejected by the sample data, accounting for the different
output of
Set.inspectin Ruby 4.Exclude Padrino and Hanami from Ruby 4 CI
Padrino and Hanami have dependencies that ultimately depend on
bundler < 3. This makes them incompatible with Ruby 4 for thetime being.
We should re-assess this after Ruby 4 is released and the affected
libraries release the necessary updates.