Skip to content

Commit

Permalink
fix: remove gap between tabs and list (#37242)
Browse files Browse the repository at this point in the history
## Description
Remove a small gap that revealed a slice of action bar.


Fixes #37220

## Automation

/ok-to-test tags="@tag.IDE"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/11688613194>
> Commit: 87b7ed8
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=11688613194&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.IDE`
> Spec:
> <hr>Tue, 05 Nov 2024 17:13:44 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Style**
- Updated the positioning and padding of the List component for improved
layout.
- Adjusted the styling of the ListContainer for better visual alignment.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
  • Loading branch information
alex-golovanov authored Nov 6, 2024
1 parent 0288f5b commit 3650796
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion app/client/src/pages/Editor/IDE/EditorTabs/List.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,9 @@ import ListQuery from "../EditorPane/Query/List";
import ListJSObjects from "../EditorPane/JS/List";

const ListContainer = styled(Flex)`
position: absolute;
top: 32px;
padding-top: 4px;
& .t--entity-item {
grid-template-columns: 0 auto 1fr auto auto auto auto auto;
height: 32px;
Expand All @@ -24,7 +27,6 @@ export const List = () => {
return (
<ListContainer
bg="var(--ads-v2-color-bg)"
className="absolute top-[36px]" // space for tabs on top and then some padding
data-testid="t--editorpane-list-view"
h="calc(100% - 32px)"
w="100%"
Expand Down

0 comments on commit 3650796

Please sign in to comment.