Fixes date widget crashing when no date format is mentioned (#322)

Fixed by using a proper default format string for ISO dates
appsmithorg · Aug 17, 2020 · 78c4b5a · 78c4b5a
1 parent 3b1c43d
commit 78c4b5a
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/app/client/src/constants/WidgetValidation.ts b/app/client/src/constants/WidgetValidation.ts
@@ -33,3 +33,5 @@ export type Validator = (
   props: WidgetProps,
   dataTree?: DataTree,
 ) => ValidationResponse;
+
+export const ISO_DATE_FORMAT = "YYYY-MM-DDTHH:mm:ss.SSSZ";
diff --git a/app/client/src/utils/Validators.ts b/app/client/src/utils/Validators.ts
@@ -1,5 +1,6 @@
 import _ from "lodash";
 import {
+  ISO_DATE_FORMAT,
   VALIDATION_TYPES,
   ValidationResponse,
   ValidationType,
@@ -392,8 +393,8 @@ export const VALIDATORS: Record<ValidationType, Validator> = {
       .minute(0)
       .second(0)
       .millisecond(0);
-    const dateFormat = props.dateFormat ? props.dateFormat : moment.ISO_8601;
-    // const dateStr = moment().toISOString();
+    const dateFormat = props.dateFormat ? props.dateFormat : ISO_DATE_FORMAT;
+
     const todayDateString = today.format(dateFormat);
     if (dateString === undefined) {
       return {