Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undo #68 #72

Merged
merged 2 commits into from
Apr 5, 2024
Merged

Undo #68 #72

merged 2 commits into from
Apr 5, 2024

Conversation

DrDaveD
Copy link
Contributor

@DrDaveD DrDaveD commented Apr 5, 2024

#68 was accidentally merged into the main branch. This reverts those commits.

Copy link

codecov bot commented Apr 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 35.28%. Comparing base (242e771) to head (31c32d3).

❗ Current head 31c32d3 differs from pull request most recent head 5fa06d8. Consider uploading reports for the commit 5fa06d8 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##             main      #72       +/-   ##
===========================================
- Coverage   51.22%   35.28%   -15.94%     
===========================================
  Files          13       13               
  Lines        1349     1349               
===========================================
- Hits          691      476      -215     
- Misses        560      788      +228     
+ Partials       98       85       -13     
Flag Coverage Δ
unittests 35.28% <ø> (-15.94%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

This reverts commit 99d07a0.

Signed-off-by: Dave Dykstra <2129743+DrDaveD@users.noreply.github.com>
This reverts commit 12c3962.

Signed-off-by: Dave Dykstra <2129743+DrDaveD@users.noreply.github.com>
@DrDaveD DrDaveD merged commit acbc137 into apptainer:main Apr 5, 2024
2 checks passed
@DrDaveD DrDaveD deleted the undo68 branch April 5, 2024 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant