Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove obsolete DownloadImage() function, from sylabs159 #75

Merged
merged 10 commits into from
Apr 5, 2024

Conversation

DrDaveD
Copy link
Contributor

@DrDaveD DrDaveD commented Apr 5, 2024

This pulls in

  • sylabs/scs-container-library#159

with original PR description of

Removes obsolete (Client).DownloadImage() function
* rename ConcurrentDownloadImage() to DownloadImage()
* rename unexported function ociDownloadBlobPart downloadBlobPart()
* unit test improvements

EmmEff added 10 commits April 5, 2024 12:41
Signed-off-by: Dave Dykstra <2129743+DrDaveD@users.noreply.github.com>
Signed-off-by: Dave Dykstra <2129743+DrDaveD@users.noreply.github.com>
Signed-off-by: Dave Dykstra <2129743+DrDaveD@users.noreply.github.com>
Signed-off-by: Dave Dykstra <2129743+DrDaveD@users.noreply.github.com>
Signed-off-by: Dave Dykstra <2129743+DrDaveD@users.noreply.github.com>
Signed-off-by: Dave Dykstra <2129743+DrDaveD@users.noreply.github.com>
Signed-off-by: Dave Dykstra <2129743+DrDaveD@users.noreply.github.com>
Signed-off-by: Dave Dykstra <2129743+DrDaveD@users.noreply.github.com>
Signed-off-by: Dave Dykstra <2129743+DrDaveD@users.noreply.github.com>
Signed-off-by: Dave Dykstra <2129743+DrDaveD@users.noreply.github.com>
Copy link

codecov bot commented Apr 5, 2024

Codecov Report

Attention: Patch coverage is 48.93617% with 48 lines in your changes are missing coverage. Please review.

Project coverage is 34.70%. Comparing base (acbc137) to head (9fbd68b).

Files Patch % Lines
client/push.go 9.75% 37 Missing ⚠️
client/oci.go 42.85% 4 Missing ⚠️
client/pull.go 66.66% 2 Missing and 1 partial ⚠️
client/api.go 83.33% 2 Missing ⚠️
client/version.go 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #75      +/-   ##
==========================================
- Coverage   35.28%   34.70%   -0.59%     
==========================================
  Files          13       13              
  Lines        1349     1314      -35     
==========================================
- Hits          476      456      -20     
+ Misses        788      781       -7     
+ Partials       85       77       -8     
Flag Coverage Δ
unittests 34.70% <48.93%> (-0.59%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DrDaveD DrDaveD merged commit a332320 into apptainer:main Apr 5, 2024
4 checks passed
@DrDaveD DrDaveD deleted the sylabs159 branch April 5, 2024 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants