-
Notifications
You must be signed in to change notification settings - Fork 39
feat: update to 1.8.0 release #42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
WalkthroughThis pull request updates Docker service images across the Appwrite stack, upgrading appwrite from 1.7.5 to 1.8.0, console from 6.0.13 to 7.4.7, assistant from 0.4.0 to 0.8.3, and executor from 0.7.14 to 0.7.22. Two new environment variables ( Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.env (1)
17-18: Resolve key ordering to match project conventions.The static analysis linter flags that
_APP_DOMAIN_TARGET_CAAand_APP_DNSare not in alphabetical order. According to dotenv-linter,_APP_DOMAIN_TARGET_CAAshould precede_APP_DOMAIN_TARGET_CNAME(line 14), and_APP_DNSshould precede_APP_DOMAIN(line 9).If your project enforces strict key ordering (likely checked in CI), reorder these variables accordingly. If not, you may safely ignore the lint warnings.
Proposed reordering (if required):
_APP_DOMAIN=localhost + _APP_DNS=8.8.8.8 _APP_CUSTOM_DOMAIN_DENY_LIST=example.com,test.com,app.example.com _APP_DOMAIN_FUNCTIONS=localhost _APP_DOMAIN_SITES=sites.localhost _APP_DOMAIN_TARGET=localhost _APP_DOMAIN_TARGET_CNAME=localhost _APP_DOMAIN_TARGET_AAAA=::1 _APP_DOMAIN_TARGET_A=127.0.0.1 + _APP_DOMAIN_TARGET_CAA= - _APP_DOMAIN_TARGET_CAA= - _APP_DNS=8.8.8.8
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
.env(1 hunks)docker-compose.yml(26 hunks)
🧰 Additional context used
🪛 dotenv-linter (4.0.0)
.env
[warning] 17-17: [UnorderedKey] The _APP_DOMAIN_TARGET_CAA key should go before the _APP_DOMAIN_TARGET_CNAME key
(UnorderedKey)
[warning] 18-18: [UnorderedKey] The _APP_DNS key should go before the _APP_DOMAIN key
(UnorderedKey)
🔇 Additional comments (3)
docker-compose.yml (3)
35-35: Verify image versions align with Appwrite 1.8.0 release.The PR updates multiple service images to versions claimed to be part of the 1.8.0 release:
appwrite/appwrite:1.8.0(all appwrite services)appwrite/console:7.4.7appwrite/assistant:0.8.3openruntimes/executor:0.7.22Confirm these versions correspond to the official Appwrite 1.8.0 release by cross-referencing the release notes at https://github.com/appwrite/appwrite/releases/tag/1.8.0.
Also applies to: 175-175, 195-195, 238-238, 264-264, 292-292, 355-355, 381-381, 449-449, 486-486, 525-525, 559-559, 610-610, 646-646, 685-685, 714-714, 742-742, 770-770, 795-795, 820-820, 845-845, 868-868
91-92: Environment variable propagation is appropriately selective.The new
_APP_DOMAIN_TARGET_CAAand_APP_DNSvariables are propagated only to services that handle domain and certificate management: the main appwrite service, appwrite-worker-certificates, appwrite-worker-migrations, and appwrite-task-maintenance. This is the correct set of services that require this configuration.Also applies to: 470-471, 629-630, 662-663
18-18: Validate the_APP_DNSdefault value.The
.envfile sets_APP_DNS=8.8.8.8(Google's public DNS). Ensure this is an appropriate default for the Gitpod development environment. If a different DNS resolver should be used (e.g., a private/internal DNS), update accordingly.
What does this PR do?
Upgrade to 1.8.0 release.
Test Plan
Manual
Related PRs and Issues
None
Have you read the Contributing Guidelines on issues?
Yes
Summary by CodeRabbit
Release Notes