Skip to content

Conversation

@stnguyen90
Copy link
Contributor

@stnguyen90 stnguyen90 commented Nov 14, 2025

What does this PR do?

Upgrade to 1.8.0 release.

Test Plan

Manual

Related PRs and Issues

None

Have you read the Contributing Guidelines on issues?

Yes

Summary by CodeRabbit

Release Notes

  • Chores
    • Upgraded appwrite core services and runtime components to latest versions.
    • Added new configuration options for domain CAA records and DNS settings.

@coderabbitai
Copy link

coderabbitai bot commented Nov 14, 2025

Walkthrough

This pull request updates Docker service images across the Appwrite stack, upgrading appwrite from 1.7.5 to 1.8.0, console from 6.0.13 to 7.4.7, assistant from 0.4.0 to 0.8.3, and executor from 0.7.14 to 0.7.22. Two new environment variables (_APP_DOMAIN_TARGET_CAA and _APP_DNS) are introduced to the .env file and propagated to the appwrite and appwrite-worker-certificates services in the docker-compose configuration. No services are added or removed, and existing wiring and dependencies remain unchanged.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • Version compatibility verification: Confirm that the specified image version bumps (particularly the minor version upgrade to appwrite 1.8.0 and console 7.4.7) are compatible with each other and support the newly introduced environment variables.
  • Environment variable support: Verify that _APP_DOMAIN_TARGET_CAA and _APP_DNS are recognized and properly handled by the target image versions, particularly for the appwrite and appwrite-worker-certificates services.
  • Configuration propagation: Ensure the new environment variables are consistently applied across all services that require them (appwrite and appwrite-worker-certificates).

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'feat: update to 1.8.0 release' accurately summarizes the main change—upgrading Appwrite and related components to version 1.8.0, which is the primary objective of the pull request.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feat-1.8.0

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@stnguyen90 stnguyen90 marked this pull request as draft November 14, 2025 23:13
@stnguyen90 stnguyen90 requested review from EVDOG4LIFE and Copilot and removed request for Copilot November 14, 2025 23:13
Copilot finished reviewing on behalf of stnguyen90 November 14, 2025 23:14
Base automatically changed from feat-1.7.5 to main November 14, 2025 23:34
@stnguyen90 stnguyen90 marked this pull request as ready for review November 14, 2025 23:35
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
.env (1)

17-18: Resolve key ordering to match project conventions.

The static analysis linter flags that _APP_DOMAIN_TARGET_CAA and _APP_DNS are not in alphabetical order. According to dotenv-linter, _APP_DOMAIN_TARGET_CAA should precede _APP_DOMAIN_TARGET_CNAME (line 14), and _APP_DNS should precede _APP_DOMAIN (line 9).

If your project enforces strict key ordering (likely checked in CI), reorder these variables accordingly. If not, you may safely ignore the lint warnings.

Proposed reordering (if required):

  _APP_DOMAIN=localhost
+ _APP_DNS=8.8.8.8
  _APP_CUSTOM_DOMAIN_DENY_LIST=example.com,test.com,app.example.com
  _APP_DOMAIN_FUNCTIONS=localhost
  _APP_DOMAIN_SITES=sites.localhost
  _APP_DOMAIN_TARGET=localhost
  _APP_DOMAIN_TARGET_CNAME=localhost
  _APP_DOMAIN_TARGET_AAAA=::1
  _APP_DOMAIN_TARGET_A=127.0.0.1
+ _APP_DOMAIN_TARGET_CAA=
- _APP_DOMAIN_TARGET_CAA=
- _APP_DNS=8.8.8.8
📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5af620b and 466fbd1.

📒 Files selected for processing (2)
  • .env (1 hunks)
  • docker-compose.yml (26 hunks)
🧰 Additional context used
🪛 dotenv-linter (4.0.0)
.env

[warning] 17-17: [UnorderedKey] The _APP_DOMAIN_TARGET_CAA key should go before the _APP_DOMAIN_TARGET_CNAME key

(UnorderedKey)


[warning] 18-18: [UnorderedKey] The _APP_DNS key should go before the _APP_DOMAIN key

(UnorderedKey)

🔇 Additional comments (3)
docker-compose.yml (3)

35-35: Verify image versions align with Appwrite 1.8.0 release.

The PR updates multiple service images to versions claimed to be part of the 1.8.0 release:

  • appwrite/appwrite:1.8.0 (all appwrite services)
  • appwrite/console:7.4.7
  • appwrite/assistant:0.8.3
  • openruntimes/executor:0.7.22

Confirm these versions correspond to the official Appwrite 1.8.0 release by cross-referencing the release notes at https://github.com/appwrite/appwrite/releases/tag/1.8.0.

Also applies to: 175-175, 195-195, 238-238, 264-264, 292-292, 355-355, 381-381, 449-449, 486-486, 525-525, 559-559, 610-610, 646-646, 685-685, 714-714, 742-742, 770-770, 795-795, 820-820, 845-845, 868-868


91-92: Environment variable propagation is appropriately selective.

The new _APP_DOMAIN_TARGET_CAA and _APP_DNS variables are propagated only to services that handle domain and certificate management: the main appwrite service, appwrite-worker-certificates, appwrite-worker-migrations, and appwrite-task-maintenance. This is the correct set of services that require this configuration.

Also applies to: 470-471, 629-630, 662-663


18-18: Validate the _APP_DNS default value.

The .env file sets _APP_DNS=8.8.8.8 (Google's public DNS). Ensure this is an appropriate default for the Gitpod development environment. If a different DNS resolver should be used (e.g., a private/internal DNS), update accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants