Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Add go 1.23 #71

Merged
merged 2 commits into from
Aug 21, 2024
Merged

Feat: Add go 1.23 #71

merged 2 commits into from
Aug 21, 2024

Conversation

Meldiron
Copy link
Contributor

What does this PR do?

Adds go 1.23 support

Test Plan

None

Related PRs and Issues

open-runtimes/open-runtimes#295

Have you read the Contributing Guidelines on issues?

Yes

@@ -109,6 +109,7 @@ public function __construct(string $version = '')

$go = new Runtime('go', 'Go', 'sh helpers/server.sh');
$go->addVersion('1.22', 'golang:1.22-alpine', 'openruntimes/go:'.$this->version.'-1.22', [System::X86, System::ARM64]);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets remove 1.22

@christyjacob4 christyjacob4 merged commit 68ea5bc into main Aug 21, 2024
6 checks passed
@christyjacob4 christyjacob4 deleted the feat-go-1.23 branch August 21, 2024 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants