Merge pull request #178 from sanogenetics/hotfix/fix-overflow-error

Fix OverflowError
apriha · Jul 19, 2024 · c2635c4 · c2635c4
2 parents 83888db + 91c4949
commit c2635c4
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/README.rst b/README.rst
@@ -267,7 +267,7 @@ Thanks to Mike Agostino, Padma Reddy, Kevin Arvai, `openSNP <https://opensnp.org
 `Open Humans <https://www.openhumans.org>`_, and `Sano Genetics <https://sanogenetics.com>`_.
 
 ``snps`` incorporates code and concepts generated with the assistance of
-`OpenAI's <https://openai.com>`_ `ChatGPT <https://chat.openai.com>`_ (GPT-3.5). ✨
+`OpenAI's <https://openai.com>`_ `ChatGPT <https://chat.openai.com>`_. ✨
 
 License
 -------

diff --git a/src/snps/snps.py b/src/snps/snps.py
@@ -1418,7 +1418,11 @@ def _remapper(self, task):
             else:
                 # mapping is on same (plus) strand, so just remap based on offset
                 offset = mapped_start - orig_start
-                temp.loc[snp_indices, "pos"] = temp["pos"] + offset
+
+                # Adjust pos by offset based on sign of offset (avoids OverflowError with uint32)
+                temp.loc[snp_indices, "pos"] = (
+                    temp["pos"] - abs(offset) if offset < 0 else temp["pos"] + offset
+                )
 
             # mark these SNPs as remapped
             temp.loc[snp_indices, "remapped"] = True