Expected behaviour for Open Download in New Tab #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix #1: Warning when using extract
Giles-5
commented
Aug 29, 2019
| @@ -4,7 +4,7 @@ | |||
| <?php endif; ?> | |||
|
|
|||
| <div class='wpcf7-download'> | |||
| <a href='<?= $url; ?>' class='<?= $button_classes; ?> wpcf7-btn' download> | |||
| <a href='<?= $url; ?>' class='<?= $button_classes; ?> wpcf7-btn' download target="<?= $target ?>"> | |||
There was a problem hiding this comment.
<a href='' class=' wpcf7-btn' download target="">
There was a problem hiding this comment.
First time trying to do this on gitHub so not sure I got it right, my code suggestion is:
<a href='<?= $url; ?>' class='<?= $button_classes; ?> wpcf7-btn' <?php if ( $target=="_blank" ) : ?>download <?php endif; ?> target="<?= $target ?>">
There was a problem hiding this comment.
sorry think I might have got comparator wrong way round, should read:
<?php if ( $target!="_blank" )
Update to support older versions of CF7
Add new show for admin feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticking Open Download in New Tab adds in target="_blank" but leaves download. This can override the target instruction. Added a quick check to see if target is specified as _blank and not to include it if true.