Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Example22 #268

Merged
merged 3 commits into from
Jan 8, 2024
Merged

Add Example22 #268

merged 3 commits into from
Jan 8, 2024

Conversation

JuanGonzalezCaminero
Copy link
Contributor

@JuanGonzalezCaminero JuanGonzalezCaminero commented Nov 30, 2023 •
edited
Loading

  • Adds new Example22:
    • New Scoring class "HostScoring"
    • Hit information is copied back to the host, no scoring is done on GPU
    • Hits are reconstructed and scoring is done on the host.
    • Sensitive volume information is now read from GDML
    • Adding new CMS Run 2 GDML file with built-in sensitive volume information
  • Benchmarking changes
    • New directory containing the test configurations used to obtain the data shown in the Geant4 2023 Assesment of R&D projects
    • New plotting scripts and minor changes to existing ones

@phsft-bot
Copy link

Can one of the admins verify this patch?

@JuanGonzalezCaminero JuanGonzalezCaminero force-pushed the add_example22 branch 4 times, most recently from 30c6788 to 095fc1d Compare December 20, 2023 14:06
@JuanGonzalezCaminero JuanGonzalezCaminero changed the title Add Example22, Do not merge Add Example22 Dec 20, 2023
@JuanGonzalezCaminero JuanGonzalezCaminero force-pushed the add_example22 branch 6 times, most recently from 03a5a46 to 13bc72c Compare December 21, 2023 14:44
@JuanGonzalezCaminero JuanGonzalezCaminero force-pushed the add_example22 branch 3 times, most recently from 5adb15f to 43cffd4 Compare December 22, 2023 10:09
@JuanGonzalezCaminero JuanGonzalezCaminero marked this pull request as ready for review December 22, 2023 15:17
agheata
agheata approved these changes Jan 8, 2024
View reviewed changes
Copy link
Contributor

@agheata agheata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging after having had a quick look only, since we are going to make a library version of example21/22 anyway.

@agheata agheata merged commit 337150a into apt-sim:master Jan 8, 2024
1 check passed
@JuanGonzalezCaminero JuanGonzalezCaminero deleted the add_example22 branch October 17, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agheata agheata agheata approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JuanGonzalezCaminero @phsft-bot @agheata