Minimal tidy of CMake scripts #277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Purely cosmetic for clarity and next step of improving linking.
|
Can one of the admins verify this patch? |
JuanGonzalezCaminero
previously approved these changes
Feb 27, 2024
JuanGonzalezCaminero
dismissed
their stale review
Seems like Cmake 3.28 doesn't work for VecCore yet
VecCore still uses CMake's long deprecated FindCUDA module, resulting in issues with policy CMP0146: https://cmake.org/cmake/help/latest/policy/CMP0146.html Reduce max CMake version to 3.24 to prevent this error until upstream is patched.
JuanGonzalezCaminero
approved these changes
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a purely cosmetic cleanup of the CMake scripts to assist in the next stage of trying to simplify the library structure and linking. Split here to avoid too much in one go. There should be no changes to build or test behaviour.